Skip to content

fix(fe): modify Invite Register Modal#3258

Open
Seohwann wants to merge 3 commits intomainfrom
t2240-modify-InviteRegsiterModal
Open

fix(fe): modify Invite Register Modal#3258
Seohwann wants to merge 3 commits intomainfrom
t2240-modify-InviteRegsiterModal

Conversation

@Seohwann
Copy link
Copy Markdown
Contributor

@Seohwann Seohwann commented Nov 4, 2025

Description

image Invite Register Modal UI 수정 했습니다 !

기능적으로 바뀐 건 없어서 css 속성값 위주로 확인 한 번만 해주세요 !

Additional context

closes TAS-2240

Before submitting the PR, please make sure you do the following

@Seohwann Seohwann requested a review from ojongii November 4, 2025 11:30
@Seohwann Seohwann self-assigned this Nov 4, 2025
@Seohwann Seohwann added this to Codedang Nov 4, 2025
@Seohwann Seohwann added 💡 feature-client 🍊squad-유자차 스쿼드 유자차 작업물입니다 labels Nov 4, 2025
@github-project-automation github-project-automation Bot moved this to Pending ✋ in Codedang Nov 4, 2025
@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Nov 4, 2025

❗ Syncing Preview App Failed

Application: frontend
Revision: da4abc2b7f1979411775e1371c5b10984e552475
Health Status: Degraded

Open Preview | View in Argo CD

@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Nov 4, 2025

✅ Syncing Preview App Succeeded

Application: frontend
Revision: a1e9364628582f02b308fcbb8d2b2f18d66a5914
Health Status: Healthy

Open Preview | View in Argo CD

@Seohwann Seohwann force-pushed the t2240-modify-InviteRegsiterModal branch from a1e9364 to 04cd886 Compare November 6, 2025 14:28
@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Nov 6, 2025

✅ Syncing Preview App Succeeded

Application: frontend
Revision: d80f36dfaa151bf944c3fa0a2de37a69bc5be971
Health Status: Healthy

Open Preview | View in Argo CD

ojongii
ojongii reviewed Nov 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ojongii ojongii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디자인과 동일하게 잘 수정해주셔서 그나마 간소화할 수 있는 CSS 속성값들을 찾아봤어요.. 참고해주세요!

Comment thread apps/frontend/app/(client)/(main)/contest/[contestId]/@tabs/_components/RegisterButton.tsx Outdated
</Button>
</DialogTrigger>
<DialogContent className="flex !h-[280px] !w-[424px] flex-col gap-5 !p-10">
<DialogContent className="flex h-[280px] w-[424px] flex-col justify-start gap-5 p-10">
Copy link
Copy Markdown
Contributor

@ojongii ojongii Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

justify-start

Copy link
Copy Markdown
Contributor Author

@Seohwann Seohwann Nov 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

없애도 괜찮은 css 속성값을 말씀해주신 거 맞나요??

Copy link
Copy Markdown
Contributor

@ojongii ojongii Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 맞습니다
기본적으로 flex-col만 있어도 justify-start으로 정렬돼서요!

Comment thread apps/frontend/app/(client)/(main)/contest/[contestId]/@tabs/_components/RegisterButton.tsx
Comment thread apps/frontend/app/(client)/(main)/contest/[contestId]/@tabs/_components/RegisterButton.tsx Outdated
Comment thread apps/frontend/app/(client)/(main)/contest/[contestId]/@tabs/_components/RegisterButton.tsx
@Seohwann Seohwann force-pushed the t2240-modify-InviteRegsiterModal branch from d80f36d to 46b121f Compare November 14, 2025 04:38
@notion-task-integration
Copy link
Copy Markdown

notion-task-integration Bot commented Nov 14, 2025 •
edited
Loading

Invite Register 모달 수정

@Seohwann Seohwann force-pushed the t2240-modify-InviteRegsiterModal branch from 46b121f to 04cd886 Compare November 14, 2025 04:40
@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Nov 14, 2025

❗ Syncing Preview App Failed

Application: frontend
Revision: 04cd886997a922530006f731c2c545d17ff37b15
Health Status: Degraded

Open Preview | View in Argo CD

@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Nov 14, 2025

❗ Syncing Preview App Failed

Application: frontend
Revision: 8d716a0ce7657470fc34f297ee27fa8633791374
Health Status: Degraded

Open Preview | View in Argo CD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ojongii ojongii ojongii left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Seohwann Seohwann

Labels

💡 feature-client 🍊squad-유자차 스쿼드 유자차 작업물입니다

Projects

Codedang
Status: Pending ✋

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Seohwann @ojongii @tasoo-oos